Paths

Table of Contentst

Update PhabricatorRepositoryManagementLookupUsersWorkflow to use ConduitCall
ClosedPublic
Actions

Authored by epriestley on Sep 2 2014, 10:52 AM.

Details

Reviewers

hach-que
btrahan

Maniphest Tasks

T2783: Make working-copy operations service-oriented

Commits

Restricted Diffusion Commit
rP4f4dc9c83e8a: Update PhabricatorRepositoryManagementLookupUsersWorkflow to use ConduitCall

Summary

Ref T2783.

This updates PhabricatorRepositoryManagementLookupUsersWorkflow to use ConduitCall to retrieve information about the commit.

Test Plan

Ran bin/repository lookup-users rTESTe9683b64d3283f0b2d355fdbf231bc918b5ac0ab --trace and saw the information returned (by making a request to diffusion.querycommits as the omnipotent user, signed with the device key).

Mucked with cluster.addresses and saw requests rejected.

Diff Detail

Repository

rP Phabricator

Branch

test2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2741
Build 3502: [Placeholder Plan] Wait for 30 Seconds
Build 2745: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25027.Sep 2 2014, 10:52 AM

hach-que retitled this revision from to Update PhabricatorRepositoryManagementLookupUsersWorkflow to use ConduitCall.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a parent revision: D10400: Implement storage of a host ID and a public key for authorizing Conduit between servers.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 2 2014, 10:52 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2411: Diff 25027.Sep 2 2014, 10:53 AM

hach-que edited the test plan for this revision. (Show Details)Sep 2 2014, 10:54 AM

hach-que edited edge metadata.

hach-que mentioned this in D10400: Implement storage of a host ID and a public key for authorizing Conduit between servers.Sep 13 2014, 3:10 AM

hach-que mentioned this in D10402: Allow Conduit requests to be signed with a public/private keypair.Oct 3 2014, 1:44 PM

hach-que mentioned this in D10401: Allow Phabricator to accept Conduit requests signed with an SSH key.Oct 3 2014, 1:51 PM

Use idx() to prevent PHP warnings

Harbormaster completed remote builds in B2741: Diff 25538.Oct 3 2014, 3:25 PM

dis mine now

Krenair added a subscriber: Krenair.Jan 2 2015, 8:55 PM

Rebase on top of the various changes which have happened on this pathway.

I'll update the metadata in a sec..

epriestley updated this object.Jan 2 2015, 9:23 PM

epriestley edited the test plan for this revision. (Show Details)

epriestley edited reviewers, added: btrahan; removed: Blessed Reviewers.

epriestley added a task: T2783: Make working-copy operations service-oriented.

btrahan accepted this revision.Jan 2 2015, 9:31 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Jan 2 2015, 9:31 PM

Closed by commit rP4f4dc9c83e8a: Update PhabricatorRepositoryManagementLookupUsersWorkflow to use ConduitCall (authored by epriestley, committed by epriestley). · Explain WhyJan 2 2015, 11:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

data/

DiffusionCommitRef.php

19 lines

repository/

management/

PhabricatorRepositoryManagementLookupUsersWorkflow.php

15 lines

Diff 25538

View Options

src/applications/diffusion/data/DiffusionCommitRef.php