[drydock/core] Abstract min-max blueprint and implement expiry logic
AbandonedPublic
Actions

Authored by hach-que on Aug 30 2014, 5:41 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T2015: Implement Drydock

Summary

Depends on D10304. This abstracts the min-max blueprint implementation into an abstract class so it can be used by other implementations. It also implements resource expiry logic, so resources can be automatically closed after they have been around for a certain period of time.

Test Plan

Tested by leasing and releasing lots of resources against the min-max test allocator.

Diff Detail

Repository

rP Phabricator

Branch

abstract-minmax

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2401
Build 2405: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25014.Aug 30 2014, 5:41 AM

hach-que retitled this revision from to Abstract min-max blueprint and implement expiry logic.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a parent revision: D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 30 2014, 5:41 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2398: Diff 25014.Aug 30 2014, 5:41 AM

hach-que added a task: T2015: Implement Drydock.Aug 30 2014, 8:43 AM

Make isTest return true for the test blueprint

Harbormaster completed remote builds in B2401: Diff 25017.Aug 30 2014, 9:32 AM

hach-que mentioned this in D10395: [drydock/aws] Implement Amazon EC2 blueprint for Drydock.Sep 11 2014, 12:12 AM

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 6:00 AM

hach-que added a project: Drydock.Jun 18 2015, 4:12 PM

hach-que retitled this revision from Abstract min-max blueprint and implement expiry logic to [drydock/core] Abstract min-max blueprint and implement expiry logic.Jul 1 2015, 4:47 AM

Depends on code which needs to yield.

This revision now requires changes to proceed.Aug 8 2015, 5:47 PM

hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 2:34 AM

I have merged this diff into D10304 since the refactor was becoming too difficult to rebase (this time around it just failed completely and I had to manually re-apply the changes).