Page MenuHomePhabricator
Differential D10371

Daemons - move combined log to console
ClosedPublic
Actions

Authored by btrahan on Aug 27 2014, 9:42 PM.
Tags
None
Referenced Files
F17909242: D10371.diff
Tue, Jul 29, 2:16 PM
F17907355: D10371.id24963.diff
Tue, Jul 29, 1:15 PM
F17898975: D10371.id24963.diff
Tue, Jul 29, 8:28 AM
F17898826: D10371.id.diff
Tue, Jul 29, 8:22 AM
F17847068: D10371.id24961.diff
Sun, Jul 27, 5:39 AM
F17838405: D10371.diff
Sat, Jul 26, 6:34 PM
Unknown Object (File)
Tue, Jul 1, 4:29 PM
Unknown Object (File)
May 31 2025, 2:15 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5405: Move daemon logs from the web UI to console-only
Commits
Restricted Diffusion Commit
rP06882a99cf92: Daemons - move combined log to console
Summary

Fixes T5405.

Test Plan

ran a few commands (log, log --id X --id Y, log --id BADX, log --id BADX --id BADY) and verified good output

Diff Detail

Repository
rP Phabricator
Branch
T5405
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2371
Build 2375: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24961.Aug 27 2014, 9:42 PM
btrahan added a task: T5405: Move daemon logs from the web UI to console-only.
btrahan retitled this revision from to Daemons - move combined log to console.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 27 2014, 9:42 PM
btrahan edited the test plan for this revision. (Show Details)Aug 27 2014, 9:42 PM
Harbormaster completed remote builds in B2371: Diff 24961.Aug 27 2014, 9:42 PM
epriestley accepted this revision.Aug 27 2014, 9:45 PM
epriestley edited edge metadata.

Cool, looks reasonable to me.

This revision is now accepted and ready to land.Aug 27 2014, 9:45 PM
btrahan closed this revision.Aug 27 2014, 9:50 PM
btrahan updated this revision to Diff 24963.

Closed by commit rP06882a99cf92 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
daemon/
application/
1 line
controller/
1 line
management/
62 lines
infrastructure/
internationalization/
translation/
4 lines

Diff 24961

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/daemon/application/PhabricatorDaemonsApplication.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonCombinedLogController.php

Loading...
View Options

src/applications/daemon/controller/PhabricatorDaemonController.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementLogWorkflow.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php

Loading...
Phabricator · Built by Phacility