Page MenuHomePhabricator

Daemons - add a config check for out of date daemon environment
ClosedPublic

Authored by btrahan on Aug 22 2014, 9:29 PM.

Details

Summary

Fixes T4881.

Test Plan

made a config change, saw the issue, restarted daemons and it went away

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Daemons - add a config check for out of date daemon environment.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Nice!

src/applications/config/check/PhabricatorSetupCheckDaemons.php
78

For clarity/consistency, missing space between $ and ./

86–87

Leftover code?

This revision is now accepted and ready to land.Aug 22 2014, 9:36 PM
src/applications/config/check/PhabricatorSetupCheckDaemons.php
69

Oh, maybe target => _blank here

btrahan edited edge metadata.

changes as requested - thanks!

btrahan updated this revision to Diff 24892.

Closed by commit rP6f246bd35190 (authored by @btrahan).