Page MenuHomePhabricator
Differential D10339

Daemons - add a config check for out of date daemon environment
ClosedPublic
Actions

Authored by btrahan on Aug 22 2014, 9:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 3:18 PM
Unknown Object (File)
Sun, Apr 14, 5:10 PM
Unknown Object (File)
Tue, Apr 9, 2:10 AM
Unknown Object (File)
Fri, Apr 5, 4:46 PM
Unknown Object (File)
Wed, Apr 3, 10:44 PM
Unknown Object (File)
Mon, Apr 1, 10:30 PM
Unknown Object (File)
Sun, Mar 31, 6:56 PM
Unknown Object (File)
Sun, Mar 24, 11:15 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Like" token, awarded by bluehawk.

Details

Reviewers
epriestley
Maniphest Tasks
T4881: When making a config change, add a banner to let the user know to restart daemons
Commits
Restricted Diffusion Commit
rP6f246bd35190: Daemons - add a config check for out of date daemon environment
Summary

Fixes T4881.

Test Plan

made a config change, saw the issue, restarted daemons and it went away

Diff Detail

Repository
rP Phabricator
Branch
T4881
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2334
Build 2338: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24889.Aug 22 2014, 9:29 PM
btrahan added a task: T4881: When making a config change, add a banner to let the user know to restart daemons.
btrahan retitled this revision from to Daemons - add a config check for out of date daemon environment.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 22 2014, 9:29 PM
Harbormaster completed remote builds in B2332: Diff 24889.Aug 22 2014, 9:31 PM
epriestley accepted this revision.Aug 22 2014, 9:36 PM
epriestley edited edge metadata.

Nice!

src/applications/config/check/PhabricatorSetupCheckDaemons.php
78

For clarity/consistency, missing space between $ and ./

86–87

Leftover code?

This revision is now accepted and ready to land.Aug 22 2014, 9:36 PM
epriestley added inline comments.Aug 22 2014, 9:36 PM
src/applications/config/check/PhabricatorSetupCheckDaemons.php
69

Oh, maybe target => _blank here

btrahan updated this revision to Diff 24891.Aug 22 2014, 9:47 PM
btrahan edited edge metadata.

changes as requested - thanks!

Harbormaster completed remote builds in B2334: Diff 24891.Aug 22 2014, 9:49 PM
btrahan closed this revision.Aug 22 2014, 9:49 PM
btrahan updated this revision to Diff 24892.

Closed by commit rP6f246bd35190 (authored by @btrahan).

bluehawk awarded a token.Aug 23 2014, 7:56 AM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
src/
applications/
config/
check/
40 lines
daemon/
event/
1 line
storage/
1 line
infrastructure/
env/
9 lines

Diff 24891

View Options

resources/sql/autopatches/20140822.daemonenvhash.sql

Loading...
View Options

src/applications/config/check/PhabricatorSetupCheckDaemons.php

Loading...
View Options

src/applications/daemon/event/PhabricatorDaemonEventListener.php

Loading...
View Options

src/applications/daemon/storage/PhabricatorDaemonLog.php

Loading...
View Options

src/infrastructure/env/PhabricatorEnv.php

Loading...
Phabricator · Built by Phacility