Page MenuHomePhabricator

Fix invalid redirect when issuing actions on buildables
ClosedPublic

Authored by hach-que on Aug 21 2014, 10:58 AM.
Tags
None
Referenced Files
F15397197: D10320.id24842.diff
Mar 16 2025, 6:44 PM
F15391984: D10320.id24843.diff
Mar 15 2025, 12:42 PM
F15360343: D10320.id24842.diff
Mar 11 2025, 8:17 AM
Unknown Object (File)
Mar 3 2025, 1:50 PM
Unknown Object (File)
Feb 27 2025, 6:33 AM
Unknown Object (File)
Feb 27 2025, 6:32 AM
Unknown Object (File)
Feb 3 2025, 5:34 AM
Unknown Object (File)
Jan 27 2025, 10:10 PM
Subscribers

Details

Summary

Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan

Restarted all builds on a buildable, saw the page reload correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Fix invalid redirect when issuing actions on buildables.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, thanks!

This revision is now accepted and ready to land.Aug 21 2014, 11:23 AM
hach-que updated this revision to Diff 24843.

Closed by commit rP1ffa16aa6b38 (authored by @hach-que).