Paths

Table of Contentst

Differential D10320

Fix invalid redirect when issuing actions on buildables
ClosedPublic
Actions

Authored by hach-que on Aug 21 2014, 10:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Sep 4, 10:43 AM

	Unknown Object (File)
	Sun, Sep 1, 12:02 AM

	Unknown Object (File)
	Sun, Sep 1, 12:02 AM

	Unknown Object (File)
	Sun, Sep 1, 12:02 AM

	Unknown Object (File)
	Sun, Sep 1, 12:01 AM

	Unknown Object (File)
	Wed, Aug 28, 1:06 PM

	Unknown Object (File)
	Tue, Aug 27, 8:37 AM

	Unknown Object (File)
	Mon, Aug 26, 2:24 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP1ffa16aa6b38: Fix invalid redirect when issuing actions on buildables

Summary

Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan

Restarted all builds on a buildable, saw the page reload correctly.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 24842.Aug 21 2014, 10:58 AM

hach-que retitled this revision from to Fix invalid redirect when issuing actions on buildables.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 21 2014, 10:58 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2306: Diff 24842.Aug 21 2014, 10:59 AM

Nice, thanks!

This revision is now accepted and ready to land.Aug 21 2014, 11:23 AM

Closed by commit rP1ffa16aa6b38 (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterBuildableActionController.php

2 lines

Diff 24843

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...