Page MenuHomePhabricator

Fix invalid redirect when issuing actions on buildables
ClosedPublic

Authored by hach-que on Aug 21 2014, 10:58 AM.
Tags
None
Referenced Files
F19639594: D10320.id24843.diff
Thu, Feb 5, 5:16 PM
F19250734: D10320.id24842.diff
Dec 22 2025, 7:50 AM
F18952377: D10320.diff
Nov 12 2025, 5:52 AM
F18828533: D10320.id24843.diff
Oct 24 2025, 4:46 PM
F18784606: D10320.diff
Oct 13 2025, 1:28 PM
F18773022: D10320.diff
Oct 9 2025, 6:27 AM
F18349258: D10320.id.diff
Aug 26 2025, 6:03 PM
F18334914: D10320.diff
Aug 25 2025, 5:51 AM
Subscribers

Details

Summary

Caught this with the new redirect validation logic. The $return_uri was being set as just B123 which is not valid. Prefixing it with / (like is done in HarbormasterBuildActionController already) gives the correct result of reloading the buildable's page.

Test Plan

Restarted all builds on a buildable, saw the page reload correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Fix invalid redirect when issuing actions on buildables.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, thanks!

This revision is now accepted and ready to land.Aug 21 2014, 11:23 AM
hach-que updated this revision to Diff 24843.

Closed by commit rP1ffa16aa6b38 (authored by @hach-que).