Differential D10267

Don't parse separator tabs as part of the filename in Git diffs which affect files with spaces
ClosedPublic
Actions

Authored by epriestley on Aug 14 2014, 4:09 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5870: Bad patch generation for diffs which remove files with spaces in their names

Commits

rARC65b6e1bdac6e: Don't parse separator tabs as part of the filename in Git diffs which affect…

Summary

Fixes T5870. When a filename contains spaces, Git will add a "\t" at the end of the "---" and "+++" lines. We currently consume this and think we're reading a file called "blah blah\t".

Instead, parse it out as not part of the filename.

Test Plan

Added failing unit test and made it pass.

Diff Detail

Repository

rARC Arcanist

Branch

rmspace

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/parser/__tests__/diff/git-remove-spaces.gitdiff:4	TXT2	Tab Literal

Unit

Tests Passed

Build Status

Buildable 2227
Build 2231: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24716.Aug 14 2014, 4:09 PM

epriestley retitled this revision from to Don't parse separator tabs as part of the filename in Git diffs which affect files with spaces.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5870: Bad patch generation for diffs which remove files with spaces in their names.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 14 2014, 4:09 PM

Harbormaster completed remote builds in B2227: Diff 24716.Aug 14 2014, 4:10 PM

nice

This revision is now accepted and ready to land.Aug 14 2014, 6:50 PM

Closed by commit rARC65b6e1bdac6e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

parser/

ArcanistDiffParser.php

4 lines

__tests__/

ArcanistDiffParserTestCase.php

6 lines

diff/

git-remove-spaces.gitdiff

11 lines

Diff 24716

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/tests/ArcanistDiffParserTestCase.php

View Options

src/parser/tests/diff/git-remove-spaces.gitdiff

Don't parse separator tabs as part of the filename in Git diffs which affect files with spacesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24716

src/parser/ArcanistDiffParser.php

src/parser/__tests__/ArcanistDiffParserTestCase.php

src/parser/__tests__/diff/git-remove-spaces.gitdiff

Don't parse separator tabs as part of the filename in Git diffs which affect files with spaces
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/tests/ArcanistDiffParserTestCase.php

src/parser/tests/diff/git-remove-spaces.gitdiff