Page MenuHomePhabricator

Bad patch generation for diffs which remove files with spaces in their names
Closed, ResolvedPublic

Description

If you remove a file with spaces in its name, arc patch can not apply the patch under Git. Here are the generated diffs:

Screen_Shot_2014-08-13_at_6.34.33_AM.png (392×497 px, 32 KB)

Removing the extra tabs on the diff --git line allows the patch to apply. These tabs are likely incorrect in all cases, but the second tab seems particularly suspicious.

Revisions and Commits

Restricted Differential Revision

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Arcanist.
epriestley added a subscriber: epriestley.

Removing the second tab is sufficient on its own.

epriestley added a revision: Restricted Differential Revision.Aug 14 2014, 4:09 PM
epriestley added a commit: Restricted Diffusion Commit.

Closed by commit rARC65b6e1bdac6e.