Page MenuHomePhabricator

Bad patch generation for diffs which remove files with spaces in their names
Closed, ResolvedPublic

Description

If you remove a file with spaces in its name, arc patch can not apply the patch under Git. Here are the generated diffs:

Screen_Shot_2014-08-13_at_6.34.33_AM.png (392×497 px, 32 KB)

Removing the extra tabs on the diff --git line allows the patch to apply. These tabs are likely incorrect in all cases, but the second tab seems particularly suspicious.