Page MenuHomePhabricator

Improve "unblock task" feed stories
ClosedPublic

Authored by epriestley on Aug 12 2014, 4:22 PM.
Tags
None
Referenced Files
F13210239: D10235.diff
Fri, May 17, 4:37 AM
F13194992: D10235.diff
Sun, May 12, 10:02 PM
F13175935: D10235.id24626.diff
Wed, May 8, 8:59 AM
Unknown Object (File)
Sun, May 5, 11:39 PM
Unknown Object (File)
Fri, May 3, 2:13 AM
Unknown Object (File)
Thu, May 2, 11:26 PM
Unknown Object (File)
Thu, May 2, 11:26 PM
Unknown Object (File)
Thu, May 2, 11:26 PM
Subscribers

Details

Summary

Fixes T5184. Fixes T5008. Three issues with stories/notifications about changing the status of tasks which block other tasks:

Bad Feed Stories

  • Problem: Feed story rendering was confusing (T5184).
  • Solution: fix it to provide context.

Too Many Feed Stories

  • Problem: Feed gets a story for the original task's close ("a closed x"), and a story for each blocked task ("a closed x, a task blocking y").
  • "Solution": Punt. These are redundant in the full feed but not in filtered feeds. Right solution is display-time aggregation. No users have really complained about this.

Too Many Notifications

  • Problem: Users subscribed to both tasks get notified about the clsoe, and also about the unblocked task. These notifications are redundant.
  • "Solution": Punt. This is easy to fix by silencing notifications for the sub-editor, but I'm worried it would be confusing. Users haven't complained. Display-time aggregation might be a better fix.
Test Plan

Screen_Shot_2014-08-12_at_9.22.20_AM.png (95×612 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped