Fixes T5838.
- We currently try to use a ConduitAPIMethod object as a string.
- We then pass that string to the parent's __construct() method as $message.
Details
Details
- Reviewers
joshuaspence btrahan - Maniphest Tasks
- T5838: Some Conduit API method exceptions do not construct messages correctly
- Commits
- Restricted Diffusion Commit
rPd09d7ffe1f2e: Fix string construction in Conduit exceptions
Uninstalled Maniphest, then tried to execute maniphest.createtask. Got a useful exception message instead of an error during message construction.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- cmethod
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2143 Build 2147: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php | ||
|---|---|---|
| 8–10 | When invoked from the subclass, this produced a string like:
| |