Paths

Table of Contentst

Differential D10211

Fix string construction in Conduit exceptions
ClosedPublic
Actions

Authored by epriestley on Aug 11 2014, 1:25 PM.

Tags

None

Referenced Files

	F14000707: D10211.diff
	Thu, Oct 24, 11:54 PM

	F13971789: D10211.id24592.diff
	Oct 17 2024, 3:21 PM

	Unknown Object (File)
	Oct 5 2024, 3:09 AM

	Unknown Object (File)
	Oct 5 2024, 3:05 AM

	Unknown Object (File)
	Sep 30 2024, 5:02 PM

	Unknown Object (File)
	Sep 24 2024, 3:25 AM

	Unknown Object (File)
	Sep 23 2024, 11:56 PM

	Unknown Object (File)
	Sep 23 2024, 2:27 AM

Subscribers

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T5838: Some Conduit API method exceptions do not construct messages correctly

Commits

Restricted Diffusion Commit
rPd09d7ffe1f2e: Fix string construction in Conduit exceptions

Summary

Fixes T5838.

We currently try to use a ConduitAPIMethod object as a string.
We then pass that string to the parent's __construct() method as $message.

Test Plan

Uninstalled Maniphest, then tried to execute maniphest.createtask. Got a useful exception message instead of an error during message construction.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24573.Aug 11 2014, 1:25 PM

epriestley retitled this revision from to Fix string construction in Conduit exceptions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T5838: Some Conduit API method exceptions do not construct messages correctly.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 11 2014, 1:25 PM

Harbormaster completed remote builds in B2143: Diff 24573.Aug 11 2014, 1:26 PM

epriestley added inline comments.Aug 11 2014, 1:27 PM

src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php
8–10	When invoked from the subclass, this produced a string like: Conduit method 'Method '<fatal during string-casting an object>' belongs to application 'Maniphest', which is not installed. does not exist.

btrahan accepted this revision.Aug 11 2014, 6:28 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 11 2014, 6:28 PM

Closed by commit rPd09d7ffe1f2e (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

conduit/

call/

ConduitCall.php

2 lines

protocol/

exception/

ConduitApplicationNotInstalledException.php

4 lines

ConduitMethodDoesNotExistException.php

12 lines

ConduitMethodNotFoundException.php

9 lines

Diff 24592

src/__phutil_library_map__.php

Loading...

src/applications/conduit/call/ConduitCall.php

Loading...

src/applications/conduit/protocol/exception/ConduitApplicationNotInstalledException.php

Loading...

src/applications/conduit/protocol/exception/ConduitMethodDoesNotExistException.php

Loading...

src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php

Loading...