Page MenuHomePhabricator

Fix string construction in Conduit exceptions
ClosedPublic

Authored by epriestley on Aug 11 2014, 1:25 PM.
Tags
None
Referenced Files
F15492897: D10211.diff
Sat, Apr 12, 7:28 PM
F15474423: D10211.id24573.diff
Sun, Apr 6, 8:40 AM
F15429598: D10211.id24573.diff
Mar 24 2025, 3:06 AM
F15416802: D10211.id.diff
Mar 20 2025, 1:37 PM
F15381503: D10211.id24573.diff
Mar 14 2025, 7:57 AM
F15366026: D10211.id24573.diff
Mar 11 2025, 2:18 PM
F15353070: D10211.diff
Mar 10 2025, 7:58 PM
F15352859: D10211.id24592.diff
Mar 10 2025, 6:48 PM
Subscribers

Details

Summary

Fixes T5838.

  • We currently try to use a ConduitAPIMethod object as a string.
  • We then pass that string to the parent's __construct() method as $message.
Test Plan

Uninstalled Maniphest, then tried to execute maniphest.createtask. Got a useful exception message instead of an error during message construction.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix string construction in Conduit exceptions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
src/applications/conduit/protocol/exception/ConduitMethodNotFoundException.php
8–10

When invoked from the subclass, this produced a string like:

Conduit method 'Method '<fatal during string-casting an object>' belongs to application 'Maniphest', which is not installed. does not exist.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 11 2014, 6:28 PM
epriestley updated this revision to Diff 24592.

Closed by commit rPd09d7ffe1f2e (authored by @epriestley).