Page MenuHomePhabricator

Improve `bin/storage upgrade` behavior when run out-of-order
ClosedPublic

Authored by epriestley on Aug 8 2014, 10:36 PM.
Tags
None
Referenced Files
F18881495: D10199.id.diff
Nov 6 2025, 9:30 PM
F18876308: D10199.diff
Nov 5 2025, 11:19 PM
F18804522: D10199.diff
Oct 18 2025, 9:12 AM
F18748859: D10199.id24541.diff
Oct 4 2025, 1:13 AM
F18721846: D10199.id.diff
Sep 29 2025, 9:43 PM
F18620860: D10199.id24542.diff
Sep 15 2025, 6:28 AM
F18403599: D10199.id.diff
Aug 29 2025, 9:23 PM
F18383334: D10199.diff
Aug 28 2025, 10:54 PM
Subscribers

Details

Summary

Fixes T5770. This error occurs if you run bin/storage upgrade before you set up MySQL credentials.

This isn't what the setup guide says to do, but it's an easy mistake to make and should be a permitted install path since there's no reason you can't do things in this order.

Specifically, we use a mixture of "standard" (configured) and "administrative" (--user and --password) credentials, and if the standard ones are bogus bad things happen. We use the standard credentials to make some initialization order stuff easier, and because there's no --host flag and adding one would be silly, and because we only need administrative credentials to issue ALTER / CREATE statements.

Test Plan

Ran with bad standard credentials; ran with bad administrative credentials. Ran with good credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Improve `bin/storage upgrade` behavior when run out-of-order.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Yeah, I might have got here in a day or so.

This revision is now accepted and ready to land.Aug 8 2014, 10:37 PM
epriestley updated this revision to Diff 24542.

Closed by commit rP237b1d769b00 (authored by @epriestley).