Page MenuHomePhabricator

Improve `bin/storage upgrade` behavior when run out-of-order
ClosedPublic

Authored by epriestley on Aug 8 2014, 10:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 19, 3:23 PM
Unknown Object (File)
Oct 17 2024, 9:36 AM
Unknown Object (File)
Oct 2 2024, 5:37 AM
Unknown Object (File)
Sep 11 2024, 10:27 PM
Unknown Object (File)
Sep 11 2024, 10:27 PM
Unknown Object (File)
Sep 4 2024, 11:31 AM
Unknown Object (File)
Aug 30 2024, 8:49 PM
Unknown Object (File)
Aug 26 2024, 5:14 PM
Subscribers

Details

Summary

Fixes T5770. This error occurs if you run bin/storage upgrade before you set up MySQL credentials.

This isn't what the setup guide says to do, but it's an easy mistake to make and should be a permitted install path since there's no reason you can't do things in this order.

Specifically, we use a mixture of "standard" (configured) and "administrative" (--user and --password) credentials, and if the standard ones are bogus bad things happen. We use the standard credentials to make some initialization order stuff easier, and because there's no --host flag and adding one would be silly, and because we only need administrative credentials to issue ALTER / CREATE statements.

Test Plan

Ran with bad standard credentials; ran with bad administrative credentials. Ran with good credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Improve `bin/storage upgrade` behavior when run out-of-order.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

Yeah, I might have got here in a day or so.

This revision is now accepted and ready to land.Aug 8 2014, 10:37 PM
epriestley updated this revision to Diff 24542.

Closed by commit rP237b1d769b00 (authored by @epriestley).