Scroll parent containers when objects are dragged near the edge of the field of view
ClosedPublic
Actions

Authored by epriestley on Aug 8 2014, 1:00 AM.

Details

Reviewers

Maniphest Tasks

T5240: Dragging items (cards, panels) could be better in Workboards

Commits

Restricted Diffusion Commit
rPe433a09fde9d: Scroll parent containers when objects are dragged near the edge of the field…

Summary

Ref T5240. This probably has some bugs and doesn't quite work in Firefox (fine on boards, not quite on the task list -- some issue with body or document being special, I think).

I think this is close enough that we can throw it out there and see how users manage to break it, though. It's not worse than what we've got now? I think?

Test Plan

dragged things near the edge of other things

they seemed to move around OK

Diff Detail

Repository

rP Phabricator

Branch

draggy2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2101
Build 2105: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24508.Aug 8 2014, 1:00 AM

epriestley retitled this revision from to Scroll parent containers when objects are dragged near the edge of the field of view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5240: Dragging items (cards, panels) could be better in Workboards.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 8 2014, 1:00 AM

Harbormaster completed remote builds in B2101: Diff 24508.Aug 8 2014, 1:01 AM

chad awarded a token.Aug 8 2014, 1:14 AM

For Firefox, would it work too on the Tasks page if there was just another div around it? (i.e. the "parent" element would not be document.body or document?) I feel like lots of folks use Firefox so I figure we'll need to get that working well before too long.

This revision is now accepted and ready to land.Aug 8 2014, 10:40 PM