Page MenuHomePhabricator

Scroll parent containers when objects are dragged near the edge of the field of view
ClosedPublic

Authored by epriestley on Aug 8 2014, 1:00 AM.

Details

Summary

Ref T5240. This probably has some bugs and doesn't quite work in Firefox (fine on boards, not quite on the task list -- some issue with body or document being special, I think).

I think this is close enough that we can throw it out there and see how users manage to break it, though. It's not worse than what we've got now? I think?

Test Plan

dragged things near the edge of other things

they seemed to move around OK

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Scroll parent containers when objects are dragged near the edge of the field of view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

For Firefox, would it work too on the Tasks page if there was just another div around it? (i.e. the "parent" element would not be document.body or document?) I feel like lots of folks use Firefox so I figure we'll need to get that working well before too long.

This revision is now accepted and ready to land.Aug 8 2014, 10:40 PM

I'm going to poke at FF and maybe comment/clean this up a little bit before I land it, I think it's probably an easy fix.

epriestley edited edge metadata.
  • Mostly fix things, probably.
  • Still has a bug when scrolling <body> in Maniphest in Firefox. I'll file that as errata.
This revision was automatically updated to reflect the committed changes.