Page MenuHomePhabricator

Add "Installed" icon to Dashboard list view.
ClosedPublic

Authored by btrahan on Aug 7 2014, 8:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 5, 6:03 PM
Unknown Object (File)
Mon, Dec 2, 7:59 PM
Unknown Object (File)
Sat, Nov 30, 2:36 AM
Unknown Object (File)
Sat, Nov 30, 2:36 AM
Unknown Object (File)
Wed, Nov 27, 3:30 AM
Unknown Object (File)
Nov 19 2024, 8:34 AM
Unknown Object (File)
Nov 18 2024, 2:37 AM
Unknown Object (File)
Nov 11 2024, 7:39 AM
Subscribers

Details

Summary

Fixes T5478. For "personal" installs use the person icon; for global use the global icon. For both providing explanatory tooltip text about what's going on. This will need to be updated if / when we start installing dashboards to other applications. Also, this query isn't 100% optimized but the major part *is* so I think its okay.

Test Plan

Installed a dashboard for personal use and verified correct icon / text showed up. Did the same for global installed dashboard...!

Diff Detail

Repository
rP Phabricator
Branch
T5478
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2090
Build 2094: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Add "Installed" icon to Dashboard list view..
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Seems reasonable to me.

This revision is now accepted and ready to land.Aug 7 2014, 8:43 PM
btrahan updated this revision to Diff 24492.

Closed by commit rP7388351aab9c (authored by @btrahan).