Page MenuHomePhabricator

Implement PhabricatorProjectInterface on ManiphestTask
ClosedPublic

Authored by epriestley on Aug 7 2014, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 6:11 AM
Unknown Object (File)
Tue, Dec 17, 4:25 AM
Unknown Object (File)
Sun, Dec 15, 9:23 PM
Unknown Object (File)
Fri, Dec 13, 7:14 AM
Unknown Object (File)
Wed, Nov 27, 4:39 PM
Unknown Object (File)
Nov 18 2024, 8:22 PM
Unknown Object (File)
Oct 18 2024, 7:46 PM
Unknown Object (File)
Oct 18 2024, 4:56 PM
Subscribers

Details

Summary

Ref T5245. This removes some hacks and activates two meaningful interactions:

  • The "projects" field goes through shared code now.
  • Mentioning projects in tasks using hashtags now tags them.
Test Plan
  • Viewed a task with projects.
  • Viewed a task with no projects.
  • Viewed a task with projects and board positions.
  • Viewed a revision with projects.
  • Made a #hashtag comment in Maniphest and got a project association.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Implement PhabricatorProjectInterface on ManiphestTask.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/project/events/PhabricatorProjectUIEventListener.php
53–55

I'm not touching this for now because I also want to redesign how the element looks and try giving these tags caret breadcrumbs, so you get:

(Project > Board)

...with the "Board" bit on a lighter background or something, and then eventually may get:

(Project > Subproject > Board)
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 7 2014, 7:43 PM
epriestley updated this revision to Diff 24498.

Closed by commit rP20d8b1bdd36a (authored by @epriestley).