Page MenuHomePhabricator
Differential D10170

Macro - allow view controller to be viewed publicly
ClosedPublic
Actions

Authored by btrahan on Aug 6 2014, 10:10 PM.
Tags
None
Referenced Files
F18820281: D10170.id.diff
Wed, Oct 22, 1:50 PM
F18819836: D10170.id.diff
Wed, Oct 22, 10:08 AM
F18812784: D10170.diff
Mon, Oct 20, 12:21 PM
F18219950: D10170.id24464.diff
Aug 19 2025, 1:15 PM
F18203373: D10170.diff
Aug 18 2025, 11:57 AM
F18088578: D10170.id24464.diff
Aug 6 2025, 8:27 AM
F18088269: D10170.id24465.diff
Aug 6 2025, 7:27 AM
F18052280: D10170.diff
Aug 4 2025, 2:02 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T5735: Macros should use "most open policy"
Commits
Restricted Diffusion Commit
rP1bd714f8ac48: Macro - allow view controller to be viewed publicly
Summary

Fixes T5735, setting up Phacility for huge financial success.

Test Plan

opened up Safari - who logs in with Safari anyway? - and could still view a macro
could also view the list of macros

Diff Detail

Repository
rP Phabricator
Branch
T5735
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2070
Build 2071: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24464.Aug 6 2014, 10:10 PM
btrahan added a task: T5735: Macros should use "most open policy".
btrahan retitled this revision from to Macro - allow view controller to be viewed publically.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 6 2014, 10:10 PM
btrahan edited the test plan for this revision. (Show Details)Aug 6 2014, 10:10 PM
Harbormaster completed remote builds in B2070: Diff 24464.Aug 6 2014, 10:11 PM
btrahan retitled this revision from Macro - allow view controller to be viewed publically to Macro - allow view controller to be viewed publicly.Aug 6 2014, 10:11 PM
epriestley accepted this revision.Aug 6 2014, 10:16 PM
epriestley edited edge metadata.

HEY I USE SAFARI ALL THE TIME

This revision is now accepted and ready to land.Aug 6 2014, 10:16 PM
btrahan added a comment.Aug 6 2014, 10:17 PM

hahaha, well, at least we know you vigorously read test plans. =D

btrahan closed this revision.Aug 6 2014, 10:17 PM
btrahan updated this revision to Diff 24465.

Closed by commit rP1bd714f8ac48 (authored by @btrahan).

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
controller/
4 lines

Diff 24464

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
Phabricator · Built by Phacility