Page MenuHomePhabricator
Create Task
Maniphest T5735

Macros should use "most open policy"
Closed, ResolvedPublic
Actions

Description

From FB, macros aren't visible when logged out on this install. They should be -- for public installs they should always be public; for nonpublic installs they should have all-user visibility.

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

epriestley created this task.Jul 29 2014, 3:40 AM
epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Macros.
epriestley added a subscriber: epriestley.
epriestley added a subscriber: btrahan.Aug 6 2014, 7:56 PM

This is probably a one-liner, and of dire import.

btrahan claimed this task.Aug 6 2014, 10:04 PM

I don't repro. T5812 has the macro showing fine in my logged out browser.

...or is it that logged out users should be able to access https://secure.phabricator.com/macro/view/129/ ? If this is the problem, then its about making a few controllers in macro allow public access.

epriestley added a comment.Aug 6 2014, 10:09 PM

or is it that logged out users should be able to access

Yerps.

btrahan added a revision: Restricted Differential Revision.Aug 6 2014, 10:10 PM
btrahan closed this task as Resolved.Aug 6 2014, 10:17 PM
btrahan added a commit: Restricted Diffusion Commit.

Closed by commit rP1bd714f8ac48.

Phabricator · Built by Phacility