Differential D10170

Macro - allow view controller to be viewed publicly
ClosedPublic
Actions

Authored by btrahan on Aug 6 2014, 10:10 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 6, 5:34 PM

	Unknown Object (File)
	Thu, Sep 5, 3:44 AM

	Unknown Object (File)
	Sun, Sep 1, 3:31 AM

	Unknown Object (File)
	Sun, Sep 1, 3:31 AM

	Unknown Object (File)
	Sun, Sep 1, 3:31 AM

	Unknown Object (File)
	Sun, Sep 1, 3:28 AM

	Unknown Object (File)
	Sun, Aug 25, 2:56 PM

	Unknown Object (File)
	Sat, Aug 24, 7:52 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T5735: Macros should use "most open policy"

Commits

Restricted Diffusion Commit
rP1bd714f8ac48: Macro - allow view controller to be viewed publicly

Summary

Fixes T5735, setting up Phacility for huge financial success.

Test Plan

opened up Safari - who logs in with Safari anyway? - and could still view a macro
could also view the list of macros

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24464.Aug 6 2014, 10:10 PM

btrahan added a task: T5735: Macros should use "most open policy".

btrahan retitled this revision from to Macro - allow view controller to be viewed publically.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 6 2014, 10:10 PM

btrahan edited the test plan for this revision. (Show Details)Aug 6 2014, 10:10 PM

Harbormaster completed remote builds in B2070: Diff 24464.Aug 6 2014, 10:11 PM

btrahan retitled this revision from Macro - allow view controller to be viewed publically to Macro - allow view controller to be viewed publicly.Aug 6 2014, 10:11 PM

HEY I USE SAFARI ALL THE TIME

This revision is now accepted and ready to land.Aug 6 2014, 10:16 PM

hahaha, well, at least we know you vigorously read test plans. =D

Closed by commit rP1bd714f8ac48 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

4 lines

Diff 24465

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...