Page MenuHomePhabricator

Macro - allow view controller to be viewed publicly
ClosedPublic

Authored by btrahan on Aug 6 2014, 10:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 11:43 PM
Unknown Object (File)
Sun, Feb 16, 3:40 AM
Unknown Object (File)
Wed, Feb 12, 12:49 AM
Unknown Object (File)
Wed, Feb 12, 12:46 AM
Unknown Object (File)
Feb 2 2025, 10:36 AM
Unknown Object (File)
Feb 1 2025, 2:47 PM
Unknown Object (File)
Jan 31 2025, 9:53 AM
Unknown Object (File)
Jan 27 2025, 5:07 PM
Subscribers

Details

Summary

Fixes T5735, setting up Phacility for huge financial success.

Test Plan

opened up Safari - who logs in with Safari anyway? - and could still view a macro
could also view the list of macros

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Macro - allow view controller to be viewed publically.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan retitled this revision from Macro - allow view controller to be viewed publically to Macro - allow view controller to be viewed publicly.Aug 6 2014, 10:11 PM
epriestley edited edge metadata.

HEY I USE SAFARI ALL THE TIME

This revision is now accepted and ready to land.Aug 6 2014, 10:16 PM

hahaha, well, at least we know you vigorously read test plans. =D

btrahan updated this revision to Diff 24465.

Closed by commit rP1bd714f8ac48 (authored by @btrahan).