Paths

Table of Contentst

Differential D10121

Add a `selectTokensOfTypes` method to the `AASTNode` class
ClosedPublic
Actions

Authored by joshuaspence on Aug 2 2014, 9:08 AM.

Tags

None

Referenced Files

	F15443317: D10121.id24346.diff
	Thu, Mar 27, 3:41 AM

	F15441642: D10121.id24343.diff
	Wed, Mar 26, 7:04 PM

	F15439087: D10121.id.diff
	Wed, Mar 26, 5:41 AM

	F15438284: D10121.diff
	Tue, Mar 25, 11:58 PM

	F15411000: D10121.diff
	Wed, Mar 19, 8:46 AM

	Unknown Object (File)
	Feb 16 2025, 4:22 PM

	Unknown Object (File)
	Feb 11 2025, 7:43 PM

	Unknown Object (File)
	Feb 9 2025, 7:45 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU5b9e5b3c105a: Add a `selectTokensOfTypes` method to the `AASTNode` class

Summary

Add a selectTokensOfTypes class which allows multiple token types to be extracted from an AASTNode.

Test Plan

This will make more sense in my next diff.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 24343.Aug 2 2014, 9:08 AM

joshuaspence retitled this revision from to Add a `selectTokensOfTypes` method to the `AASTNode` class.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 2 2014, 9:08 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2001: Diff 24343.Aug 2 2014, 9:10 AM

epriestley accepted this revision.Aug 2 2014, 9:13 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/parser/aast/api/AASTNode.php
145	Avoid `array_merge()` in a loop. Probably easiest here to just iterate over the results explicitly rather than trying to `array_mergev()` later on. https://secure.phabricator.com/book/phabflavor/article/php_pitfalls/#array-merge-in-incredibl

This revision is now accepted and ready to land.Aug 2 2014, 9:13 AM

Don't use array_merge inside a loop

Harbormaster completed remote builds in B2002: Diff 24344.Aug 2 2014, 9:43 AM

Closed by commit rPHU5b9e5b3c105a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

30 lines

Diff 24346

src/parser/aast/api/AASTNode.php

Loading...