Page MenuHomePhabricator
Differential D10112

Use standard infrastructure for Audit email generation
ClosedPublic
Actions

Authored by epriestley on Aug 1 2014, 7:38 PM.
Tags
None
Referenced Files
F18755936: D10112.diff
Sun, Oct 5, 8:16 AM
F18755268: D10112.id24335.diff
Sun, Oct 5, 4:44 AM
F18726670: D10112.id.diff
Tue, Sep 30, 6:49 AM
F18716429: D10112.diff
Mon, Sep 29, 11:59 AM
F18621405: D10112.diff
Mon, Sep 15, 8:09 AM
F18047790: D10112.id.diff
Aug 3 2025, 1:09 PM
F17949633: D10112.id24335.diff
Jul 31 2025, 11:44 PM
F17931415: D10112.id24318.diff
Jul 30 2025, 6:58 PM
View All Files
Subscribers
epriestley
staticshock

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T4896: Move Audit to ApplicationTransactions
Commits
Restricted Diffusion Commit
rP64736264a62d: Use standard infrastructure for Audit email generation
Summary

Ref T4896. Replace custom stuff with standard stuff.

Test Plan
  • Sent a bunch of email and it all looked sensible/correct.
  • Made sure to test inlines, specifically, as they're a bit tricky.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/audit/storage/PhabricatorAuditTransaction.php:182XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 1988
Build 1989: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24318.Aug 1 2014, 7:38 PM
epriestley retitled this revision from to Use standard infrastructure for Audit email generation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
epriestley added a task: T4896: Move Audit to ApplicationTransactions.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 1 2014, 7:38 PM
Harbormaster completed remote builds in B1988: Diff 24318.Aug 1 2014, 7:40 PM
btrahan accepted this revision.Aug 1 2014, 8:09 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 8:09 PM
epriestley closed this revision.Aug 2 2014, 7:06 AM
epriestley updated this revision to Diff 24335.

Closed by commit rP64736264a62d (authored by @epriestley).

staticshock added a subscriber: staticshock.Sep 8 2014, 7:55 PM
staticshock added inline comments.
src/applications/audit/storage/PhabricatorAuditTransaction.php
57

Clsoed

missedthat

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
225 lines
119 lines
storage/
51 lines

Diff 24318

View Options

src/applications/audit/editor/PhabricatorAuditCommentEditor.php

Loading...
View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransaction.php

Loading...
Phabricator · Built by Phacility