Page MenuHomePhabricator

Use standard infrastructure for Audit email generation
ClosedPublic

Authored by epriestley on Aug 1 2014, 7:38 PM.
Tags
None
Referenced Files
F18755936: D10112.diff
Sun, Oct 5, 8:16 AM
F18755268: D10112.id24335.diff
Sun, Oct 5, 4:44 AM
F18726670: D10112.id.diff
Tue, Sep 30, 6:49 AM
F18716429: D10112.diff
Mon, Sep 29, 11:59 AM
F18621405: D10112.diff
Mon, Sep 15, 8:09 AM
F18047790: D10112.id.diff
Aug 3 2025, 1:09 PM
F17949633: D10112.id24335.diff
Jul 31 2025, 11:44 PM
F17931415: D10112.id24318.diff
Jul 30 2025, 6:58 PM

Details

Summary

Ref T4896. Replace custom stuff with standard stuff.

Test Plan
  • Sent a bunch of email and it all looked sensible/correct.
  • Made sure to test inlines, specifically, as they're a bit tricky.

Diff Detail

Repository
rP Phabricator
Branch
audit4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/audit/storage/PhabricatorAuditTransaction.php:182XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 1988
Build 1989: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Use standard infrastructure for Audit email generation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 8:09 PM
epriestley updated this revision to Diff 24335.

Closed by commit rP64736264a62d (authored by @epriestley).

staticshock added inline comments.
src/applications/audit/storage/PhabricatorAuditTransaction.php
57

Clsoed

missedthat