Page MenuHomePhabricator

Provide a transaction editor to perform Audit row writes
ClosedPublic

Authored by epriestley on Aug 1 2014, 6:56 PM.
Tags
None
Referenced Files
F19868105: D10109.diff
Sun, Mar 15, 1:30 AM
F19812544: D10109.diff
Wed, Mar 4, 5:24 AM
F19612608: D10109.diff
Feb 3 2026, 7:25 PM
F19522019: D10109.id.diff
Jan 17 2026, 3:39 AM
F19519260: D10109.id.diff
Jan 16 2026, 3:40 AM
F19514615: D10109.id.diff
Jan 14 2026, 3:33 AM
F19304396: D10109.id24314.diff
Dec 24 2025, 10:41 AM
F19103448: D10109.diff
Dec 5 2025, 10:12 AM
Subscribers

Details

Summary

Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan
  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Diff Detail

Repository
rP Phabricator
Branch
audit2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1985
Build 1986: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Provide a transaction editor to perform Audit row writes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:03 PM
epriestley updated this revision to Diff 24333.

Closed by commit rP5b969fb5b809 (authored by @epriestley).