Page MenuHomePhabricator

Provide a transaction editor to perform Audit row writes
ClosedPublic

Authored by epriestley on Aug 1 2014, 6:56 PM.
Tags
None
Referenced Files
F18709085: D10109.id24314.diff
Sun, Sep 28, 11:41 PM
F18705154: D10109.diff
Sun, Sep 28, 10:22 AM
F18703949: D10109.id.diff
Sun, Sep 28, 5:39 AM
F18654378: D10109.diff
Mon, Sep 22, 7:33 AM
F18654128: D10109.id24333.diff
Mon, Sep 22, 3:28 AM
F18375816: D10109.diff
Aug 28 2025, 10:23 AM
F18047788: D10109.id.diff
Aug 3 2025, 1:09 PM
F17954958: D10109.id24333.diff
Aug 1 2025, 4:27 AM
Subscribers

Details

Summary

Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan
  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Provide a transaction editor to perform Audit row writes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:03 PM
epriestley updated this revision to Diff 24333.

Closed by commit rP5b969fb5b809 (authored by @epriestley).