Page MenuHomePhabricator

Provide a transaction editor to perform Audit row writes
ClosedPublic

Authored by epriestley on Aug 1 2014, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 26, 12:25 AM
Unknown Object (File)
Tue, Aug 25, 10:39 AM
Unknown Object (File)
Sun, Aug 16, 11:20 AM
Unknown Object (File)
Jun 19 2026, 10:29 PM
Unknown Object (File)
Jun 13 2026, 1:56 AM
Unknown Object (File)
Jun 5 2026, 5:38 AM
Unknown Object (File)
Jun 1 2026, 9:19 PM
Unknown Object (File)
Apr 12 2026, 3:33 PM
Subscribers

Details

Summary

Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan
  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Provide a transaction editor to perform Audit row writes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:03 PM
epriestley updated this revision to Diff 24333.

Closed by commit rP5b969fb5b809 (authored by @epriestley).