Page MenuHomePhabricator

Provide a transaction editor to perform Audit row writes
ClosedPublic

Authored by epriestley on Aug 1 2014, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 5, 9:17 AM
Unknown Object (File)
Sat, Aug 31, 3:35 PM
Unknown Object (File)
Sun, Aug 25, 7:36 AM
Unknown Object (File)
Sun, Aug 25, 7:23 AM
Unknown Object (File)
Thu, Aug 22, 11:59 PM
Unknown Object (File)
Thu, Aug 22, 11:59 PM
Unknown Object (File)
Thu, Aug 22, 11:59 PM
Unknown Object (File)
Mon, Aug 19, 2:15 PM
Subscribers

Details

Summary

Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan
  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Provide a transaction editor to perform Audit row writes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:03 PM
epriestley updated this revision to Diff 24333.

Closed by commit rP5b969fb5b809 (authored by @epriestley).