Page MenuHomePhabricator

Provide a transaction editor to perform Audit row writes
ClosedPublic

Authored by epriestley on Aug 1 2014, 6:56 PM.
Tags
None
Referenced Files
F15457768: D10109.id24314.diff
Sun, Mar 30, 6:44 PM
F15443778: D10109.id24333.diff
Thu, Mar 27, 6:07 AM
F15443760: D10109.id.diff
Thu, Mar 27, 6:02 AM
F15440295: D10109.diff
Wed, Mar 26, 11:58 AM
F15435902: D10109.id24314.diff
Tue, Mar 25, 10:49 AM
F15435901: D10109.id24333.diff
Tue, Mar 25, 10:49 AM
F15380064: D10109.id24333.diff
Fri, Mar 14, 1:14 AM
F15375325: D10109.diff
Wed, Mar 12, 10:32 PM
Subscribers

Details

Summary

Ref T4896. Replaces more custom stuff with standard stuff. In particular:

  • No more fake proxy writes;
  • no more fake detection of @mentions.

For now, the old code still applies most of the effects and handles feed and email.

Test Plan
  • Added comments.
  • Added comments with inline comments.
  • Added just inline comments.
  • Added comments with Conduit.
  • Previewed comments.
  • Added CCs explicitly and with @mentions.
  • Added auditors.
  • Accepted a commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Provide a transaction editor to perform Audit row writes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 7:03 PM
epriestley updated this revision to Diff 24333.

Closed by commit rP5b969fb5b809 (authored by @epriestley).