Paths

Table of Contentst

Always install JX.log, even in production
ClosedPublic
Actions

Authored by epriestley on Aug 1 2014, 1:33 AM.

Tags

None

Referenced Files

	F14052061: D10104.diff
	Fri, Nov 15, 6:10 AM

	F14040534: D10104.diff
	Mon, Nov 11, 10:55 AM

	F14022399: D10104.diff
	Wed, Nov 6, 5:01 PM

	F14007812: D10104.id24301.diff
	Tue, Oct 29, 11:53 AM

	F14006290: D10104.id24301.diff
	Mon, Oct 28, 5:22 AM

	F13980775: D10104.id24302.diff
	Oct 19 2024, 12:28 PM

	F13980767: D10104.id24301.diff
	Oct 19 2024, 12:28 PM

	F13980722: D10104.id.diff
	Oct 19 2024, 12:21 PM

View All Files

Subscribers

epriestley

Tokens

"Manufacturing Defect?" token, awarded by joshuaspence.

Details

Reviewers

hach-que
joshuaspence
btrahan

Maniphest Tasks

T5366: Provide tools to assist administrators in setting up Aphlict

Commits

Restricted Diffusion Commit
rP5cd269609d2b: Always install JX.log, even in production

Summary

Ref T5366. Currently, enabling notification.debug fails to produce any messages unless developer mode is also enabled.

There's no reason we need to disable JX.log in production, and the byte size of the method is very small. Always provide a real JX.log implementation.

Test Plan

Saw notification debugging without needing to enable developer mode.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24301.Aug 1 2014, 1:33 AM

epriestley retitled this revision from to Always install JX.log, even in production.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: hach-que, btrahan, joshuaspence.

epriestley added a task: T5366: Provide tools to assist administrators in setting up Aphlict.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 1 2014, 1:33 AM

hach-que accepted this revision.Aug 1 2014, 1:34 AM

hach-que edited edge metadata.

This revision is now accepted and ready to land.Aug 1 2014, 1:34 AM

Harbormaster completed remote builds in B1977: Diff 24301.Aug 1 2014, 1:34 AM

Closed by commit rP5cd269609d2b (authored by @epriestley).

joshuaspence awarded a token.Aug 1 2014, 4:53 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

15 lines

webroot/

rsrc/

externals/

javelin/

core/

util.js

37 lines

Diff 24302

View Options

resources/celerity/map.php