Page MenuHomePhabricator
Differential D10104

Always install JX.log, even in production
ClosedPublic
Actions

Authored by epriestley on Aug 1 2014, 1:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 7:17 AM
Unknown Object (File)
Thu, Jan 23, 8:07 PM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Thu, Jan 23, 2:46 PM
Unknown Object (File)
Fri, Jan 17, 2:13 AM
Unknown Object (File)
Sun, Jan 12, 12:25 AM
View All Files
Subscribers
epriestley
Tokens
"Manufacturing Defect?" token, awarded by joshuaspence.

Details

Reviewers
hach-que
joshuaspence
btrahan
Maniphest Tasks
T5366: Provide tools to assist administrators in setting up Aphlict
Commits
Restricted Diffusion Commit
rP5cd269609d2b: Always install JX.log, even in production
Summary

Ref T5366. Currently, enabling notification.debug fails to produce any messages unless developer mode is also enabled.

There's no reason we need to disable JX.log in production, and the byte size of the method is very small. Always provide a real JX.log implementation.

Test Plan

Saw notification debugging without needing to enable developer mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24301.Aug 1 2014, 1:33 AM
epriestley retitled this revision from to Always install JX.log, even in production.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: hach-que, btrahan, joshuaspence.
epriestley added a task: T5366: Provide tools to assist administrators in setting up Aphlict.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 1 2014, 1:33 AM
hach-que accepted this revision.Aug 1 2014, 1:34 AM
hach-que edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 1:34 AM
Harbormaster completed remote builds in B1977: Diff 24301.Aug 1 2014, 1:34 AM
epriestley closed this revision.Aug 1 2014, 1:38 AM
epriestley updated this revision to Diff 24302.

Closed by commit rP5cd269609d2b (authored by @epriestley).

joshuaspence awarded a token.Aug 1 2014, 4:53 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
15 lines
webroot/
rsrc/
externals/
javelin/
core/
37 lines

Diff 24302

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/externals/javelin/core/util.js

Loading...
Phabricator · Built by Phacility