Page MenuHomePhabricator

Always install JX.log, even in production
ClosedPublic

Authored by epriestley on Aug 1 2014, 1:33 AM.
Tags
None
Referenced Files
F19857324: D10104.id24301.diff
Fri, Mar 13, 11:55 PM
F19832841: D10104.id24302.diff
Wed, Mar 11, 12:20 AM
F19153772: D10104.diff
Dec 11 2025, 12:05 PM
F19097687: D10104.id.diff
Dec 4 2025, 2:37 PM
F19062260: D10104.id24301.diff
Nov 29 2025, 3:24 PM
F18892478: D10104.diff
Nov 7 2025, 12:00 PM
F18749520: D10104.diff
Oct 4 2025, 4:08 AM
F18712033: D10104.id.diff
Sep 29 2025, 5:15 AM
Subscribers
Tokens
"Manufacturing Defect?" token, awarded by joshuaspence.

Details

Summary

Ref T5366. Currently, enabling notification.debug fails to produce any messages unless developer mode is also enabled.

There's no reason we need to disable JX.log in production, and the byte size of the method is very small. Always provide a real JX.log implementation.

Test Plan

Saw notification debugging without needing to enable developer mode.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Always install JX.log, even in production.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
hach-que edited edge metadata.
This revision is now accepted and ready to land.Aug 1 2014, 1:34 AM
epriestley updated this revision to Diff 24302.

Closed by commit rP5cd269609d2b (authored by @epriestley).