Page MenuHomePhabricator

Revert attempt to fix mail in differential
ClosedPublic

Authored by btrahan on Jul 31 2014, 9:46 PM.
Tags
None
Referenced Files
F13219298: D10101.id24291.diff
Sat, May 18, 5:10 PM
F13196167: D10101.diff
Sun, May 12, 11:01 PM
Unknown Object (File)
Fri, May 3, 3:14 AM
Unknown Object (File)
Mon, Apr 29, 2:42 PM
Unknown Object (File)
Fri, Apr 26, 3:33 AM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Wed, Apr 24, 6:20 PM
Subscribers

Details

Summary

This fix is wrong - should be load and not get - but moreover this is actually correctly set as the reply handler is instantiated inside the DifferentialRevisionMailReceiver correctly; $this->getExclude was correct. Ref T5185.

Test Plan

this shall stop the fatal in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Revert attempt to fix mail in differential.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 31 2014, 9:48 PM
btrahan updated this revision to Diff 24291.

Closed by commit rPc4cbc1a32da7 (authored by @btrahan).