Revert attempt to fix mail in differential
ClosedPublic
Actions

Authored by btrahan on Jul 31 2014, 9:46 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email

Commits

Restricted Diffusion Commit
rPc4cbc1a32da7: Revert attempt to fix mail in differential

Summary

This fix is wrong - should be load and not get - but moreover this is actually correctly set as the reply handler is instantiated inside the DifferentialRevisionMailReceiver correctly; $this->getExclude was correct. Ref T5185.

Test Plan

this shall stop the fatal in production.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 24289.Jul 31 2014, 9:46 PM

btrahan retitled this revision from to Revert attempt to fix mail in differential.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 31 2014, 9:46 PM

Harbormaster completed remote builds in B1973: Diff 24289.Jul 31 2014, 9:47 PM

epriestley accepted this revision.Jul 31 2014, 9:48 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 31 2014, 9:48 PM

Closed by commit rPc4cbc1a32da7 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialReplyHandler.php

14 lines

Diff 24291

View Options

src/applications/differential/mail/DifferentialReplyHandler.php

Revert attempt to fix mail in differentialClosedPublicActions