Differential D10085

Macros - fix audio disabling not actually disabling audio
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 9:11 PM.

Tags

None

Referenced Files

	F15368534: D10085.diff
	Wed, Mar 12, 2:44 AM

	F15343663: D10085.id24250.diff
	Mon, Mar 10, 12:11 AM

	Unknown Object (File)
	Mon, Mar 3, 9:59 AM

	Unknown Object (File)
	Fri, Feb 14, 2:13 PM

	Unknown Object (File)
	Wed, Feb 12, 4:21 AM

	Unknown Object (File)
	Wed, Feb 12, 4:17 AM

	Unknown Object (File)
	Wed, Feb 12, 4:17 AM

	Unknown Object (File)
	Wed, Feb 12, 4:09 AM

Subscribers

Details

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rP8d520fbae3d7: Macros - fix audio disabling not actually disabling audio

Summary

Fixes T5653.

Test Plan

made a macro with sound and it played. changed it to not play and it did not play. changed it back and it played once more.

Diff Detail

Repository

Branch

T5653

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/applications/phragment/controller/PhragmentZIPController.php:54	PHL1	Unknown Symbol
Error	src/applications/phragment/controller/PhragmentZIPController.php:70	PHL1	Unknown Symbol
Error	src/applications/phragment/storage/PhragmentFragment.php:143	PHL1	Unknown Symbol

Unit

No Test Coverage

Build Status

Buildable 1944
Build 1945: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24249.Jul 30 2014, 9:11 PM

btrahan added a task: Restricted Maniphest Task.

btrahan retitled this revision from to Macros - fix audio disabling not actually disabling audio.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 30 2014, 9:11 PM

epriestley accepted this revision.Jul 30 2014, 9:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 30 2014, 9:11 PM

Harbormaster completed remote builds in B1944: Diff 24249.Jul 30 2014, 9:12 PM

Closed by commit rP8d520fbae3d7 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

remarkup/

PhabricatorRemarkupRuleImageMacro.php

4 lines

Diff 24249

src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php

Loading...