Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F15343663
D10085.id24250.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
647 B
Referenced Files
None
Subscribers
None
D10085.id24250.diff
View Options
diff --git a/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php b/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
--- a/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
+++ b/src/applications/macro/remarkup/PhabricatorRemarkupRuleImageMacro.php
@@ -124,7 +124,9 @@
$id = null;
$audio = idx($files, $macro->getAudioPHID());
- if ($audio) {
+ $should_play = ($audio && $macro->getAudioBehavior() !=
+ PhabricatorFileImageMacro::AUDIO_BEHAVIOR_NONE);
+ if ($should_play) {
$id = celerity_generate_unique_node_id();
$loop = null;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Mar 11, 12:11 AM (1 d, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
7483131
Default Alt Text
D10085.id24250.diff (647 B)
Attached To
Mode
D10085: Macros - fix audio disabling not actually disabling audio
Attached
Detach File
Event Timeline
Log In to Comment