Page MenuHomePhabricator
Differential D10084

Calendar - fix inline display of status icon
ClosedPublic
Actions

Authored by btrahan on Jul 30 2014, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 26, 7:43 AM
Unknown Object (File)
Dec 5 2024, 7:58 AM
Unknown Object (File)
Dec 5 2024, 5:56 AM
Unknown Object (File)
Dec 2 2024, 5:54 AM
Unknown Object (File)
Nov 30 2024, 12:35 AM
Unknown Object (File)
Nov 18 2024, 8:55 PM
Unknown Object (File)
Nov 18 2024, 6:19 PM
Unknown Object (File)
Oct 23 2024, 6:02 AM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T5663: Away indicator from Calendar corrupted
Commits
Restricted Diffusion Commit
rPf3cc0c20189d: Calendar - fix inline display of status icon
Summary

Fixes T5663. Said task kind of stalled out and maybe @chad wanted to take a different approach, but this works? Also, I think fixing any new bugs that may emerge with more reasonable css scoping seems like a reasonable path forward.

Test Plan

inline display of status icon looked correct in differential

Diff Detail

Repository
rP Phabricator
Branch
T5663
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1946
Build 1947: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24247.Jul 30 2014, 8:54 PM
btrahan added a task: T5663: Away indicator from Calendar corrupted.
btrahan retitled this revision from to Calendar - fix inline display of status icon.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
btrahan added a subscriber: chad.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 30 2014, 8:54 PM
Harbormaster completed remote builds in B1943: Diff 24247.Jul 30 2014, 8:56 PM
chad edited edge metadata.Jul 30 2014, 8:56 PM

This breaks down when viewing side by side colored diffs, the padding makes the bright green/red fit the height of the overall line color.

chad added a comment.Jul 30 2014, 8:58 PM

the 'easy' fix is to add an additional rule that targets just the dot inside remarkup-code. Kind of ick, but no idea when we'd fix this rule overall.

epriestley edited edge metadata.Jul 30 2014, 9:04 PM

.remarkup-code td > span (that is, add a >) miiight also work? Kind of a long shot.

btrahan updated this revision to Diff 24252.Jul 30 2014, 9:19 PM
btrahan edited edge metadata.

try the > version...

Fixes the issue but not sure about the red / green break happening. See screenshot in a second.

btrahan added a comment.Jul 30 2014, 9:20 PM

Screen_Shot_2014-07-30_at_2.22.52_PM.png (1×2 px, 390 KB)

(basically I have really crappy test data. Is this diff good enough or should I try something really complicated?)

Harbormaster completed remote builds in B1946: Diff 24252.Jul 30 2014, 9:20 PM
btrahan added a comment.Jul 30 2014, 9:21 PM

that said... if i use firebug or what have you i can see the new css rule is being applied to the green spans. :D

chad accepted this revision.Jul 31 2014, 3:19 AM
chad edited edge metadata.

shipitquick

This revision is now accepted and ready to land.Jul 31 2014, 3:19 AM
btrahan closed this revision.Jul 31 2014, 7:36 PM
btrahan updated this revision to Diff 24287.

Closed by commit rPf3cc0c20189d (authored by @btrahan).

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
css/
core/
2 lines

Diff 24252

View Options

webroot/rsrc/css/core/syntax.css

Loading...
Phabricator · Built by Phacility