Page MenuHomePhabricator

Away indicator from Calendar corrupted
Closed, ResolvedPublic

Description

If a user has entered event in Calendar app and it matches today (e.g. Vacation), then a red dot is displayed before his username anywhere in the system.

However in commit inline comments font of username is different (taller) and red dot is converted into red vertical bar with rounder corners (see attached images):
{F179397}

{F179396}

Event Timeline

aik099 raised the priority of this task from to Needs Triage.
aik099 updated the task description. (Show Details)
aik099 added projects: Audit, Diffusion, Calendar.
aik099 added a subscriber: aik099.

there is a lot of CSS leakage from syntax-highlighting

If this is messy we can wait for T5654 / T1460, which will probably touch this stuff heavily.

I think I can just remove span padding since we already set line height on the td. At least, I can't find it breaking anything specific in differential or diffusion.

Is there a single source to where these span's are built @epriestley? Derping around yields nothing concrete. Was thinking of changing the 'span' to 'var' or other inline element for changeset rendering.

The syntax highlighting spans aren't built in a single place.

The user spans are built in PhabricatorRemarkupRuleMention.