been some changes here and this code was broked. turns out we re-assign $action like two lines later and never used the initial value, so we can simply delete the offending line. Fixes T5745.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T5745: Unable to post only inline comments to an audit
- Commits
- Restricted Diffusion Commit
rP98c2ad38e564: Fix audit commenting where there are only inlines
submitted inline comment pre-patch and fatal. re-submitted post patch and great success!
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T5745
- Lint
Lint Errors Severity Location Code Message Error src/applications/phragment/controller/PhragmentZIPController.php:54 PHL1 Unknown Symbol Error src/applications/phragment/controller/PhragmentZIPController.php:70 PHL1 Unknown Symbol Error src/applications/phragment/storage/PhragmentFragment.php:143 PHL1 Unknown Symbol - Unit
No Test Coverage - Build Status
Buildable 1937 Build 1938: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
We swapped to a different datasource for the "which things are native in PHP", it might be missing ZipArchive.