Page MenuHomePhabricator
Differential D10072

trivial typo
ClosedPublic
Actions

Authored by cburroughs on Jul 29 2014, 2:21 PM.
Tags
None
Referenced Files
F14409679: D10072.diff
Tue, Dec 24, 6:58 AM
Unknown Object (File)
Thu, Dec 5, 12:38 PM
Unknown Object (File)
Nov 19 2024, 6:06 AM
Unknown Object (File)
Oct 23 2024, 8:31 AM
Unknown Object (File)
Oct 17 2024, 7:56 AM
Unknown Object (File)
Oct 16 2024, 1:51 AM
Unknown Object (File)
Oct 15 2024, 10:12 PM
Unknown Object (File)
Oct 15 2024, 3:15 PM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP6f21cfbe10a6: trivial typo
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

There is a typo in one of the example mail test commands.

Test Plan

Read the command, maybe even paste it.

Diff Detail

Repository
rP Phabricator
Branch
trivial-typo
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1927
Build 1928: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

cburroughs updated this revision to Diff 24224.Jul 29 2014, 2:21 PM
cburroughs retitled this revision from to trivial typo.
cburroughs updated this object.
cburroughs edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 29 2014, 2:21 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1927: Diff 24224.Jul 29 2014, 2:22 PM
epriestley added a comment.Jul 29 2014, 4:06 PM

Ah, thanks! Can you sign the CLA?

epriestley requested changes to this revision.Jul 30 2014, 8:52 PM
epriestley added a reviewer: epriestley.

(Just pushing it back to your queue for CLA.)

This revision now requires changes to proceed.Jul 30 2014, 8:52 PM
cburroughs added a comment.Aug 19 2014, 6:10 PM

Not sure what the right button to press is to get this out of 'Needs Revision' now that the document is signed.

cburroughs requested a review of this revision.Aug 28 2014, 9:18 PM
cburroughs edited edge metadata.

It's entirely possible -- reasonable even -- that the 'Request Review' action will kick this out of 'Needs Revision'.

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 7:51 AM
joshuaspence added a comment.Feb 27 2015, 10:07 PM

@cburroughs, you need to sign L28 Phacility Individual Contributor License Agreement.

cburroughs added a comment.Feb 27 2015, 11:55 PM

"You signed this document on Aug 19 2014, 2:08 PM."

I see a green checkmark too. I think I sent this before I signed and had mucked with the state to try to get it to 'take' back in August.

epriestley accepted this revision.Feb 27 2015, 11:58 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 27 2015, 11:58 PM
epriestley added a comment.Feb 27 2015, 11:59 PM

Sorry this took a year to merge.

Move fast and break things!

Closed by commit rP6f21cfbe10a6: trivial typo (authored by cburroughs, committed by epriestley). · Explain WhyFeb 28 2015, 12:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
docs/
user/
configuration/
2 lines

Diff 24224

View Options

src/docs/user/configuration/configuring_inbound_email.diviner

Loading...
Phabricator · Built by Phacility