Page MenuHomePhabricator

Use authoritative PHIDs for Herald "Task Projects" condition
ClosedPublic

Authored by epriestley on Jul 26 2014, 12:07 PM.
Tags
None
Referenced Files
F18047764: D10060.diff
Sun, Aug 3, 1:08 PM
F18019776: D10060.id24188.diff
Sat, Aug 2, 7:33 PM
F17959992: D10060.id24186.diff
Fri, Aug 1, 8:44 AM
F17891408: D10060.id.diff
Tue, Jul 29, 3:55 AM
F17867927: D10060.diff
Mon, Jul 28, 6:56 AM
Unknown Object (File)
Jun 20 2025, 7:52 AM
Unknown Object (File)
Jun 19 2025, 6:20 AM
Unknown Object (File)
Apr 24 2025, 5:04 PM
Subscribers

Details

Summary

Fixes T5707. After work on T5245, the $task object may not have the correct set of task PHIDs attached to it when Herald is invoked.

Instead, just fetch the authoritative set. This is simple, and Herald is not super performance sensitive (happens on a write) so hitting the DB once is fine.

Test Plan

Created a task with projects, verified the projects field contained the correct values when processed by Herald.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Use authoritative PHIDs for Herald "Task Projects" condition.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.
This revision is now accepted and ready to land.Jul 26 2014, 1:47 PM
epriestley updated this revision to Diff 24188.

Closed by commit rP0b5fcb36ae8c (authored by @epriestley).