Page MenuHomePhabricator

Make external link/refresh use provider IDs, switch external account MFA to one-shot
ClosedPublic

Authored by epriestley on Feb 7 2019, 1:43 AM.
Tags
None
Referenced Files
F13233670: D20117.diff
Tue, May 21, 2:29 AM
F13233069: D20117.diff
Tue, May 21, 1:40 AM
F13215969: D20117.id48130.diff
Fri, May 17, 9:28 PM
F13211522: D20117.diff
Fri, May 17, 5:50 AM
F13198589: D20117.id.diff
Mon, May 13, 8:09 AM
F13195229: D20117.diff
Sun, May 12, 10:14 PM
F13178044: D20117.diff
Wed, May 8, 8:07 PM
Unknown Object (File)
Sun, May 5, 4:48 PM
Subscribers
None

Details

Summary

Depends on D20113. Ref T6703. Continue moving toward a future where multiple copies of a given type of provider may exist.

Switch MFA from session-MFA at the start to one-shot MFA at the actual link action.

Add one-shot MFA to the unlink action. This theoretically prevents an attacker from unlinking an account while you're getting coffee, registering alIce which they control, adding a copy of your profile picture, and then trying to trick you into writing a private note with your personal secrets or something.

Test Plan

Linked and unlinked accounts. Refreshed account. Unlinked, then registered a new account. Unlinked, then relinked to my old account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable