Page MenuHomePhabricator

During first-time setup, create an administrator account with no authentication instead of weird, detached authentication
ClosedPublic

Authored by epriestley on Feb 6 2019, 11:33 PM.
Tags
None
Referenced Files
F13291668: D20111.id48020.diff
Wed, Jun 5, 12:09 AM
F13290202: D20111.id48020.diff
Tue, Jun 4, 6:02 PM
F13256790: D20111.id48127.diff
Sat, May 25, 5:32 PM
F13256762: D20111.id.diff
Sat, May 25, 4:59 PM
F13250930: D20111.id48020.diff
Fri, May 24, 6:33 PM
F13241344: D20111.id.diff
Wed, May 22, 8:29 PM
F13231063: D20111.diff
Tue, May 21, 12:06 AM
F13230703: D20111.diff
Mon, May 20, 11:16 PM
Subscribers

Details

Summary

Ref T6703. Currently, when you create an account on a new install, we prompt you to select a password.

You can't actually use that password unless you set up a password provider, and that password can't be associated with a provider since a password provider won't exist yet.

Instead, just don't ask for a password: create an account with a username and an email address only. Setup guidance points you toward Auth.

If you lose the session, you can send yourself an email link (if email works yet) or bin/auth recover it. This isn't really much different than the pre-change behavior, since you can't use the password you set anyway until you configure password auth.

This also makes fixing T9512 more important, which I'll do in a followup. I also plan to add slightly better guideposts toward Auth.

Test Plan

Hit first-time setup, created an account.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable