HomePhabricator

(PhabricatorIRCProtocolAdapter.connect) Use recommended connection registration…

Description

(PhabricatorIRCProtocolAdapter.connect) Use recommended connection registration order from RFC{1459,2812}

http://tools.ietf.org/html/rfc1459.html#section-4.1 and http://tools.ietf.org/html/rfc2812#section-3.1
mentions that client should send the PASS first, then the latter of NICK/USER.

This is tested and confirmed working with ngircd commit 485d0aec813db9966922f17aae044df2d82b0b67

See: https://github.com/facebook/phabricator/pull/524

Reviewed by: epriestley

Details

Group Auditors
Cowboy Commits
Provenance
RockjAuthored on
epriestleyCommitted on Mar 4 2014, 7:15 PM
epriestleyPushed on Mar 4 2014, 7:15 PM
Reviewer
epriestley
Parents
rPd1e64e64ffff: Workboards - add transactions for column changes
Branches
Unknown
Tags
Unknown

Event Timeline