HomePhabricator

Use persistent database connections from web contexts

Description

Use persistent database connections from web contexts

Summary:
Ref T11672. Depends on D16577. When establishing a connection from a webserver context, try to use persistent connections.

The hope is that this will fix outbound port exhaustion issues experienced on repository hosts handling large queue volumes.

Test Plan:
Added this to a page:

$tables = array(
  new PhabricatorUser(),
  new ManiphestTask(),
  new DifferentialRevision(),
  new PhabricatorRepository(),
  new PhabricatorPaste(),
);

$ids = array();
foreach ($tables as $table) {
  $conn = $table->establishConnection('r');

  $cid = queryfx_one(
    $conn,
    'SELECT CONNECTION_ID() cid');

  $ids[get_class($table)] = $cid['cid'];
}

var_dump($ids);

Reloaded the page a bunch of times and saw no reissued connections (the pool seems to keep a particular connection bound to a particular database), but did see connection reuse across requests.

That is, across reloads the same connection IDs appeared, but the same connection ID never appeared twice in the same request. This is what we want.

Also googled for issues with persistent connections, but everything I found was unconcerning and obscure (local variables and other very complex state that we don't use), and a bunch of the docs are reassuring (transactions, etc., get reset properly).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11672

Differential Revision: https://secure.phabricator.com/D16578

Details

Provenance
epriestleyAuthored on Sep 20 2016, 2:30 PM
epriestleyPushed on Sep 21 2016, 9:46 PM
Reviewer
chad
Differential Revision
D16578: Use persistent database connections from web contexts
Parents
rP0817eb14a94b: Update Phurl to use EditEngine
Branches
Unknown
Tags
Unknown
Tasks
T11672: Evaluate persistent connections from HTTP contexts
Build Status
Buildable 13801
Build 17835: Run Core Tests