HomePhabricator

Return `$this` from setter methods

Description

Return $this from setter methods

Summary: Return $this from setter methods for consistency. I started writing a linter rule to detect this, but I don't think it is trivial to do this properly.

Test Plan: Eyeball it.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D13422

Details

Provenance
joshuaspenceAuthored on
joshuaspencePushed on Jul 6 2015, 12:54 PM
Reviewer
Blessed Reviewers
Differential Revision
D13422: Return `$this` from setter methods
Parents
rPacb1eb81ccf4: Move some PhabricatorSearchField subclasses
Branches
Unknown
Tags
Unknown