HomePhabricator

Make Herald transcripts policy-aware

Description

Make Herald transcripts policy-aware

Summary:
Ref T603. Herald transcripts potentially leak a bunch of content (task text, revision/commit content). Don't let users see them if they can't see the actual objects.

This is a little messy but ends up mostly reasonable-ish.

Test Plan:

  • Verified that transcripts for objects I couldn't see no longer appear in the list, and reject access.
  • Verified that transcripts for objects in applications I can't see reject access, albeit less gracefully.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7221

Details

Provenance
epriestleyAuthored on Oct 4 2013, 10:17 PM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rPa235768d586e: Modernize "Test Console" and fix a minor display bug with "Always"
Branches
Unknown
Tags
Unknown
Tasks
T603: Support permissions/policies in all Phabricator applications

Event Timeline