Convert a low-level VCS query in Diff extraction to a Conduit call
da3963b009ce
Actions

Description

Convert a low-level VCS query in Diff extraction to a Conduit call

Summary: Ref T9319. Ref T2783. This won't currently work in a future environment where daemons and repositories are not on the same host. Send it over Conduit instead.

Test Plan: Used bin/differential attach-commit rX Dy to force attachment, saw valid content pull over Conduit.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2783, T9319

Differential Revision: https://secure.phabricator.com/D14969

Details

Provenance

epriestley	Authored on
epriestley	Pushed on Jan 8 2016, 5:28 PM

Reviewer

chad

Differential Revision

D14969: Convert a low-level VCS query in Diff extraction to a Conduit call

Parents

rP413ca12fda6b: Move commit attachment to a separate CLI command

Branches

Unknown

Tags

Unknown

Tasks

T2783: Make working-copy operations service-oriented
T9319: Accessing image file in Diffusion must not generate error (unhandled exception)

Build Status

Buildable 10003
Build 12091: Run Core Tests

Event Timeline

epriestley committed rPda3963b009ce: Convert a low-level VCS query in Diff extraction to a Conduit call (authored by epriestley).Jan 8 2016, 5:28 PM

epriestley added a task: T9319: Accessing image file in Diffusion must not generate error (unhandled exception).

epriestley added a task: T2783: Make working-copy operations service-oriented.

Harbormaster completed building B10003: rPda3963b009ce: Convert a low-level VCS query in Diff extraction to a Conduit call.Jan 8 2016, 5:28 PM

Changes (1)

Path

Size

src/

applications/

differential/

engine/

DifferentialDiffExtractionEngine.php

rPda3963b009ce

View Options

src/applications/differential/engine/DifferentialDiffExtractionEngine.php