Fix migration on conpherence images
Description
Description
Details
Details
- Auditors
epriestley chad - Group Auditors
Cowboy Commits - Provenance
Chad Little <chad@phacility.com> Authored on Oct 5 2016, 7:29 PM chad Pushed on Oct 5 2016, 7:29 PM - Parents
- rPd68c444ffada: Convert Conpherence to use normal picture setting flows
- Branches
- Unknown
- Tags
- Build Status
Buildable 14023 Build 18188: Run Core Tests
Event Timeline
Comment Actions
If anyone ran the old version of this in the 10 seconds the old version was in HEAD, you can get to the right state with:
$ ./bin/storage upgrade --apply phabricator:20161005.conpherence.image.2.php| /resources/sql/autopatches/20161005.conpherence.image.2.php | ||
|---|---|---|
| 16 | We may also need: if (!$file_phid) {
continue;
} | |
| 22 | And maybe: if (!$file) {
continue;
}...but we can see if any users hit issues. | |
Comment Actions
They're OK as-is if no one runs into issues.
They could only be problems if users had manually destroyed files with bin/remove destroy or something like that, I think. Reasonable chance no installs have, since there's no reason to destroy a room profile photo.