Fix migration on conpherence images
Partially Auditedcc230ed98a25

Authored by chad on Oct 5 2016, 7:29 PM.

Description

Fix migration on conpherence images

Details

Auditors
chad
Group Auditors
Cowboy Commits
H64 Triggered Audit
Committed
chadOct 5 2016, 7:29 PM
Pushed
chadOct 5 2016, 7:29 PM
Parents
rPd68c444ffada: Convert Conpherence to use normal picture setting flows
Branches
Unknown
Tags
Unknown

If anyone ran the old version of this in the 10 seconds the old version was in HEAD, you can get to the right state with:

$ ./bin/storage upgrade --apply phabricator:20161005.conpherence.image.2.php
/resources/sql/autopatches/20161005.conpherence.image.2.php
16

We may also need:

if (!$file_phid) {
  continue;
}
22

And maybe:

if (!$file) {
  continue;
}

...but we can see if any users hit issues.

chad added a comment.Oct 7 2016, 3:24 AM

Oh sorry, these need fixed?

chad raised a concern with this commit.Oct 7 2016, 3:25 AM

They're OK as-is if no one runs into issues.

They could only be problems if users had manually destroyed files with bin/remove destroy or something like that, I think. Reasonable chance no installs have, since there's no reason to destroy a room profile photo.

chad accepted this commit.Oct 15 2016, 12:04 AM