Paths

Table of Contentst

Properly create xhpast database
Auditedcbde56cdce1a
Actions

Description

Properly create xhpast database

Summary:
It isn't deleted by storage destroy.

This should be a no-op on current storage because we execute CREATE DATABASE IF NOT EXISTS.

Test Plan:

$ bin/storage destroy --dryrun

Reviewers: nh, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3659

Details

Auditors

btrahan

Provenance

vrana

Authored on

Reviewer

epriestley

Differential Revision

Restricted Differential Revision

Parents

rP2bc9ac5e2ee2: Show upload status, success and failures for drag-and-drop files in…

Branches

Unknown

Tags

Unknown

Event Timeline

I am getting unit test failures that say things like

[2012-10-09 14:55:51] EXCEPTION: (AphrontQuerySchemaException) #1049: Unknown database 'phabricator_unittest_jfrvp5pb7bwwljnbcsrmr2lp_xhprof' at [/Users/btrahan/Dropbox/code/libphutil/src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php:249]

when trying to run the new version of the sql file.

/resources/sql/patches/xhprof.sql
1	shouldn't it be CREATE DATABASE IF NOT EXISTS on this side, not just a delete?

Did you run storage upgrade?

Thanks: D3670.

Thanks for the fix in D3670...! :)

Changes (2)

Path

Size

resources/

sql/

patches/

xhprof.sql

src/

infrastructure/

storage/

patch/

PhabricatorBuiltinPatchList.php

rPcbde56cdce1a

View Options

resources/sql/patches/xhprof.sql