HomePhabricator

Move all comment management junk into a dropdown menu

Description

Move all comment management junk into a dropdown menu

Summary:
man I sure hate Javascript

I removed the ajax-edit and ajax-remove interactions, becuase they were prohibitively complex to get working given that the entire menu has to change too. Instead, the page just reloads. This works perfectly fine in practice.

If we want to restore these in the future, we should have the server re-render the entire transaction group or something. I think very little is lost here, though.

Test Plan:

  • Took all the actions.
  • Used existing dropdown menus.

Screen_Shot_2014-05-03_at_1.11.50_PM.png (757×897 px, 84 KB)

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8966

Details

Provenance
epriestleyAuthored on
epriestleyPushed on May 5 2014, 5:57 PM
Reviewer
btrahan
Differential Revision
D8966: Move all comment management junk into a dropdown menu
Parents
rP5a5a1ca444a3: Delete all old dropdown menu code
Branches
Unknown
Tags
Unknown

Event Timeline