HomePhabricator

Add a `(dst, type, src)` key to Differential's edge table

Description

Add a (dst, type, src) key to Differential's edge table

Summary:
Ref T1279. This came to me in a dream.

The existing differential_relationship table has an (objectPHID, type) column, which theoretically is useful for queries like "revisions with X as a reviewer". In practice, I'm not sure it gets used much, but I can get it to show up in at least some query plans.

Add a similar index to the edge table. This sequences before D7227, which actually migrates the data.

Test Plan:

  • Ran bin/storage upgrade.
  • EXPLAIN'd a bunch of queries against different versions of the schema, this seemed helpful overall.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7232

Conflicts:
src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php

Details

Provenance
epriestleyAuthored on Oct 5 2013, 11:49 AM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rPe6d8e1a00ac4: Make Herald rules obey policies during application
Branches
Unknown
Tags
Unknown
Tasks
T1279: Show per-reviewer status in Differential revision reviewer list

Event Timeline