HomePhabricator

When Favorites is uninstalled or not visible to the viewer, hide the menu

Description

When Favorites is uninstalled or not visible to the viewer, hide the menu

Summary: Ref T5867. The executeOne() currently raises a policy exception if the application isn't visible to the viewer, or we fatal if the application has been uninstalled.

Test Plan:

  • Viewed pages with the application uninstalled, saw working pages with no favorites menu.
  • Viewed pages with the application restricted, saw working pages with no favorites menu.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T5867

Differential Revision: https://secure.phabricator.com/D17219

Details

Provenance
epriestleyAuthored on Jan 18 2017, 2:05 PM
epriestleyPushed on Jan 18 2017, 3:45 PM
Reviewer
chad
Differential Revision
D17219: When Favorites is uninstalled or not visible to the viewer, hide the menu
Parents
rP0513a242352e: Fix a bad constant in "audit.query"
Branches
Unknown
Tags
Unknown
Tasks
T5867: Move Quick Create to MenuItemEngine
Build Status
Buildable 15307
Build 20146: Run Core Tests