HomePhabricator

Fix a self-XSS hole in Diffusion

Description

Fix a self-XSS hole in Diffusion

Summary:
Via HackerOne. We aren't correctly escaping the date, so a user can XSS themselves by setting their date format creatively.

This construction is very unusual and I don't think we do anything similar elsewhere, so I can't come up with a systematic change which would prevent this in the general case.

Test Plan: Set date format to tag junk, got self-XSS before patch and proper escaping after the patch.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D12117

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Mar 20 2015, 9:54 PM
Reviewer
chad
Differential Revision
D12117: Fix a self-XSS hole in Diffusion
Parents
rP80b8dc521d14: Fix Mercurial command injection vulnerability
Branches
Unknown
Tags
Unknown