HomePhabricator
Diffusion Phabricator a778151f28c1

Fix errors found by PHPStan
a778151f28c1
Actions

Description

Fix errors found by PHPStan

Test Plan: Ran phpstan analyze -a autoload.php phabricator/src.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, hach-que

Differential Revision: https://secure.phabricator.com/D17371

Details

Provenance
vranaAuthored on Feb 17 2017, 10:10 AM
industryPushed on Feb 17 2017, 10:10 AM
Reviewer
Blessed Reviewers
Differential Revision
D17371: Fix errors found by PHPStan
Parents
rPb2739710ba74: Don't allow forms which can't create objects to be added to profile menus
Branches
Unknown
Tags
Unknown
Build Status
Buildable 15672
Build 20697: Run Core Tests

Changes (80)

PathSize
src/
applications/
auth/
controller/
badges/
controller/
base/
calendar/
__tests__/
storage/
conduit/
controller/
config/
check/
controller/
option/
schema/
conpherence/
conduit/
dashboard/
controller/
engine/
differential/
customfield/
query/
diffusion/
conduit/
controller/
management/
query/
diviner/
atom/
renderer/
workflow/
herald/
controller/
query/
legalpad/
controller/
storage/
lipsum/
generator/
maniphest/
controller/
field/
metamta/
adapter/
storage/
owners/
customfield/
paste/
query/
xaction/
people/
customfield/
phame/
storage/
phid/
pholio/
controller/
phragment/
storage/
phriction/
conduit/
policy/
controller/
ponder/
controller/
project/
controller/
customfield/
icon/
releeph/
query/
repository/
query/
storage/
search/
engine/
storage/
slowvote/
controller/
spaces/
controller/
tokens/
storage/
transactions/
view/
infrastructure/
daemon/
bot/
adapter/
storage/
lisk/
util/
password/
view/
form/
control/
layout/
phui/
calendar/

rPa778151f28c1

View Options

src/applications/auth/controller/PhabricatorAuthUnlinkController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesAwardController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php

Loading...
View Options

src/applications/base/PhabricatorApplication.php

Loading...
View Options

src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitController.php

Loading...
View Options

src/applications/config/check/PhabricatorDaemonsSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorPHPConfigSetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorSecuritySetupCheck.php

Loading...
View Options

src/applications/config/check/PhabricatorStorageSetupCheck.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterDatabasesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterNotificationsController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigClusterRepositoriesController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...
View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

Loading...
View Options

src/applications/config/schema/PhabricatorConfigKeySchema.php

Loading...
View Options

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php

Loading...
View Options

src/applications/dashboard/controller/PhabricatorDashboardManageController.php

Loading...
View Options

src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php

Loading...
View Options

src/applications/differential/customfield/DifferentialCustomField.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionRequiredActionResultBucket.php

Loading...
View Options

src/applications/diffusion/conduit/DiffusionDiffQueryConduitAPIMethod.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionHistoryController.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryStatusManagementPanel.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitRequiredActionResultBucket.php

Loading...
View Options

src/applications/diviner/atom/DivinerAtom.php

Loading...
View Options

src/applications/diviner/renderer/DivinerDefaultRenderer.php

Loading...
View Options

src/applications/diviner/workflow/DivinerWorkflow.php

Loading...
View Options

src/applications/herald/controller/HeraldController.php

Loading...
View Options

src/applications/herald/query/HeraldRuleQuery.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentEditController.php

Loading...
View Options

src/applications/legalpad/controller/LegalpadDocumentManageController.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocumentBody.php

Loading...
View Options

src/applications/lipsum/generator/PhabricatorTestDataGenerator.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestController.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/maniphest/field/ManiphestConfiguredCustomField.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerAdapter.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailImplementationPHPMailerLiteAdapter.php

Loading...
View Options

src/applications/metamta/storage/PhabricatorMetaMTAAttachment.php

Loading...
View Options

src/applications/owners/customfield/PhabricatorOwnersConfiguredCustomField.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteQuery.php

Loading...
View Options

src/applications/paste/xaction/PhabricatorPasteTitleTransaction.php

Loading...
View Options

src/applications/people/customfield/PhabricatorUserConfiguredCustomField.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/phid/utils.php

Loading...
View Options

src/applications/pholio/controller/PholioMockViewController.php

Loading...
View Options

src/applications/phragment/storage/PhragmentFragment.php

Loading...
View Options

src/applications/phriction/conduit/PhrictionInfoConduitAPIMethod.php

Loading...
View Options

src/applications/policy/controller/PhabricatorPolicyExplainController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersAddController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersRemoveController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectSilenceController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectUpdateController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectWatchController.php

Loading...
View Options

src/applications/project/customfield/PhabricatorProjectConfiguredCustomField.php

Loading...
View Options

src/applications/project/icon/PhabricatorProjectIconSet.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryURIQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/search/engine/PhabricatorProfileMenuEngine.php

Loading...
View Options

src/applications/search/storage/PhabricatorSavedQuery.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvoteVoteController.php

Loading...
View Options

src/applications/spaces/controller/PhabricatorSpacesListController.php

Loading...
View Options

src/applications/tokens/storage/PhabricatorTokensToken.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/infrastructure/daemon/bot/adapter/PhabricatorStreamingProtocolAdapter.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
View Options

src/infrastructure/util/password/PhabricatorPasswordHasher.php

Loading...
View Options

src/view/form/control/AphrontFormTextAreaControl.php

Loading...
View Options

src/view/layout/AphrontSideNavFilterView.php

Loading...
View Options

src/view/phui/PHUITimelineView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
Phabricator · Built by Phacility