Fix errors found by PHPStan
ClosedPublic

Authored by vrana on Feb 16 2017, 3:09 PM.

Details

Test Plan

Ran phpstan analyze -a autoload.php phabricator/src.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vrana created this revision.Feb 16 2017, 3:09 PM
epriestley accepted this revision.Feb 16 2017, 4:12 PM
epriestley added inline comments.
src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php
10

This test case is no longer doing anything with $day so I think it can't be right, but I can try to figure that out and follow up.

src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php
13–19

We should just remove this: it has no callsites and was improperly copy-pasted. This object has no status, inviterPHID, etc., properties, so this code will fatal even with this fix.

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php
52–53

I think this case can just be removed instead. Conpherence threads are no longer required to have a title (if they don't, we'll create a default one by listing the participants) and I think this just never got cleaned up.

ERROR_EMPTY_MESSAGE should be impossible when creating a thread and I think it only refs to sending an empty message to an existing thread.

This revision is now accepted and ready to land.Feb 16 2017, 4:12 PM
vrana updated this revision to Diff 41775.Feb 17 2017, 10:09 AM

Address feedback

src/applications/calendar/__tests__/CalendarTimeUtilTestCase.php
10

I've changed it to getTimestamps($u, $day, 1) and the test now passes.

src/applications/calendar/storage/PhabricatorCalendarExternalInvitee.php
13–19

Note that it returns PhabricatorCalendarEventInvitee, not PhabricatorCalendarExternalInvitee. I'll submit it like this and let you follow up.

src/applications/conpherence/conduit/ConpherenceCreateThreadConduitAPIMethod.php
52–53

Removed.

This revision was automatically updated to reflect the committed changes.