HomePhabricator

Fix controller-level access rules

Description

Fix controller-level access rules

Summary:
Ref T603. I had to partially revert this earlier because it accidentally blocked access to Conduit and File data for installs without "policy.allow-public", since the applications are available to "all users" but some endpoints actually need to be available even when not logged in.

This readjusts the gating in the controller to properly apply application visibility restrictions, and then adds a giant pile of unit test coverage to make sure it sticks and all the weird cases are covered.

Test Plan:

  • Added and executed unit tests.
  • Executed most of the tests manually, by using logged in / admin / public / disabled users.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7211

Details

Provenance
epriestleyAuthored on Oct 4 2013, 2:05 AM
Reviewer
btrahan
Differential Revision
Restricted Differential Revision
Parents
rP3cf17cc67f29: Herald - add field + condition for Diffusion Commits for "On autoclose branch"
Branches
Unknown
Tags
Unknown
Tasks
T603: Support permissions/policies in all Phabricator applications

Event Timeline