HomePhabricator

Merge PhutilGitURI into PhutilURI

Description

Merge PhutilGitURI into PhutilURI

Summary:
Ref T11137. This addresses three general issues:

  • From T11137, I recently added a bad typehint.
  • From T11004, we currently have buggy behavior with Git URIs that have relative paths: we convert them into "ssh://" URIs but change the meaning of their paths.
  • Generally, Phabricator has a lot of instanceof-flavored code around URI handling, and this has been a frequent source of errors. See some discussion in T11137. See next revision for changes to Phabricator.

Test Plan: Unit tests; see next revision for field testing.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11137

Differential Revision: https://secure.phabricator.com/D16099

Details

Provenance
epriestleyAuthored on Jun 13 2016, 12:03 PM
epriestleyPushed on Jun 13 2016, 2:20 PM
Reviewer
chad
Differential Revision
D16099: Merge PhutilGitURI into PhutilURI
Parents
rPHUad458fb7df59: (stable) Promote 2016 Week 24
Branches
Unknown
Tags
Unknown
Tasks
T11137: Unable to update Git repositories with latest stable
Build Status
Buildable 12615
Build 16016: Run Core Tests